On Sun, Sep 28, 2008 at 11:57:05AM +0200, Matthieu Moy wrote: > > Neat. I started on something like this quite a while ago, > > Did you publish/send it anywhere? No, I was waiting to clean it up and test it a bit more. > Well, OTOH, one could argue that "blame" is based on diff-ing, and > therefore it's natural to define a diff filter to tell how "blame" > should work. Yes, I would have made that argument. ;) > > [diff "foo"] > > xfuncname = "some regex" > > binary = auto > > No sure that would actually be useful in real life, but it doesn't > harm to have it. And the argument "better path forward for defining > sets of diff tweaks" is a good one IMO. Yes, I think currently most diff options supersede the decision about whether or not it's binary (like textconv, in which you probably assume the result is diff-able as text). xfuncname doesn't, but the example is perhaps a bit contrived. So I do think of it as more of a way for future expansion. I seem to recall actually running into this as part of the textconv work I was doing, but now I can't remember the exact details. So that's not that compelling an argumen.t :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
