On Sat, Sep 27, 2008 at 11:51:24AM -0400, Marcus Griep wrote: > > Overall, looks good, though Alex's comment of using "cygwin.nativestat" may > be a better descriptor for the config flag. Perhaps... but I am not sure about policy for options in config file. core.cygwinnativestat was proposed by Shawn, so I would like to hear his opinion. > I also think there is more refactoring that could be done, with there being > common code paths still existing in MinGW and Cygwin. I am not sure that there is much common code left: stat structures are different in MinGW and Cygwin (different fields and their types), and I do not think having one function with a lot of #ifdef __CYGWIN__ in it is actual improvement. But you can send a patch on top of mine and let other people decide if it is a worty goal. Dmitry -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
