Hi Marcus, On Sat, Sep 27, 2008 at 03:02:06AM -0400, Marcus Griep wrote: > > This is a substitute patch that takes care of many of the concerns already > posted to this thread regarding the patch. Sorry if it steps on your toes, > Dmitry. You began scratching my itch, so I wanted to jump in and scratch > some more. I am sorry I was not able to send my patches earlier. I had them ready by the end of the day when we had the discussion, but I have not had an opportunity to test it on Windows till today. I have only skimmed over your patch, but there are a few changes that I really dislike about your patch. You changed the semantic of _choice functions. While I use it as stubs to choose what implementation to use, you make them part of implementation, which is always called. So I do not understand why you left the comment saying that they are only stubs and then why you need function pointers at all then. Also, you made some changes to MinGW (I don't know if you tested it), but any change like removing _getdrive() from MinGW version is better to move into separately patch (or, at least, clearly state them in the commit comment). Anyway, thanks for your efforts, but if you want to go ahead with some other match of mine (especially Windows related), please, let me know, so we can avoid stepping on each other toes. Dmitry -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
