On 26 Sep 2008, at 5:40 PM, Jeff King wrote:
I think overall this serious is well-intentioned the results look sane
to me (I diffed the manpage and usage text before and after).
My only concerns are:
4/6: ...
The manpage, on the other hand, is a comprehensive reference and
so should probably be alphabetized for easy reading.
I can buy it. I'll change it back.
...
That being said, I find the length of the current usage
statement
somewhat ridiculous.
I'll take care of it.
5/6: This isn't really a documentation patch, as it adds a new config
option. I think the result is reasonable, but it was a surprise
after reading the rest of the series.
I didn't mean to mark those as Docs. I'll fix that too.
I was also going to complain that there was no entry in
Documentation/config.txt for the new option, but I see that none
of the sendemail options are there. Maybe while you are working
on this, it is worth factoring them out to send-email-
options.txt
and including it in both git-send-email.txt and config.txt.
Grumble grumble grumble... erm.. hmm.. grrr.. ok.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
