On Wednesday 24 September 2008 20:52:01 Shawn O. Pearce wrote: > Alexander Gavrilov <angavrilov@xxxxxxxxx> wrote: > > - Make citool return nonzero exit code if it did not commit. > > - Add a mode where it does not actually commit and simply > > exits with zero code. Commit message is either disabled, > > or simply dumped to GITGUI_EDITMSG before exiting. > > - Add an option to immediately start it in amend mode. > ... > > I think this functionality might be useful, in particular for some of > > my own scripts. But I'm not sure if this is the best way to do it. > > This looks good to me, but I think we may want to add this as a > follow-up patch. Thoughts? > > --8<-- > git-gui: Hide commit related UI during citool --nocommit > > If the user started git-gui as "git citool --nocommit" then they > don't need the new commit / amend commit radio buttons, or the sign > off button in the UI. Rather than use up space with options the > user cannot activate they are simply not installed into the UI. > > Signed-off-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> > --- I believe that the 'Sign Off' button should better be controlled by the nocommitmsg option; otherwise this looks good to me. But I'm not the best thinker at the moment (had a cold). Alexander -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
