On Thursday 25 September 2008, Shawn O. Pearce wrote: > Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote: > > Did you test it? The command inside $(...) is run in its own > > sub-process, therefore, the die() does not exit the caller, just > > the sub-process, and the || exit *is* required. > > > > BTW, I think that || exit is sufficient; you don't need to add > > another error message - the one that resolve_relative_url() prints > > is sufficient. > > Exactly. > > I think we just need a "|| exit" after each of these > $(resolve_relative_url) calls. The original patch that > started this discussion just needs a "|| exit". The original patch did exactly that: http://article.gmane.org/gmane.comp.version-control.git/96493 Have fun! ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
