Re: [PATCH v2] maint: check return of split_cmdline to avoid bad config strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 24, 2008 at 10:50:29AM -0400, Deskin Miller <deskinm@xxxxxxxxx> wrote:
> As the testcase demonstrates, it's possible for split_cmdline to return -1 and
> deallocate any memory it's allocated, if the config string is missing an end
> quote.  In both the cases below, which are the only calling sites, the return
> isn't checked, and using the pointer causes a pretty immediate segfault.
> 
> Signed-off-by: Deskin Miller <deskinm@xxxxxxxxx>

Acked-by: Miklos Vajna <vmiklos@xxxxxxxxxxxxxx>

Thanks.

Attachment: pgpxDKIrckdfo.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux