Re: [PATCH 1/3] for-each-ref: utilize core.warnambiguousrefs for strict refname:short format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> writes:

> diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
> index 9b44092..e7b7712 100644
> --- a/builtin-for-each-ref.c
> +++ b/builtin-for-each-ref.c
> @@ -571,7 +571,7 @@ static void gen_scanf_fmt(char *scanf_fmt, const char *rule)
>  /*
>   * Shorten the refname to an non-ambiguous form
>   */
> -static char *get_short_ref(struct refinfo *ref)
> +static void get_short_ref(struct refinfo *ref, int strict, char **short_ref)
>  {
>  	int i;
>  	static char **scanf_fmts;

As far as I can tell this changing of function signature does not help its
existing caller nor the function's implementation.

Why?  And especially why do this in a patch that does something else?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux