Alexander Gavrilov schrieb: > On Monday 22 September 2008 11:25:43 Johannes Sixt wrote: >> Alexander Gavrilov schrieb: >>> Subject: [PATCH] gitk: Implement batch lookup and caching of encoding attrs. >>> >>> When the diff contains thousands of files, calling git-check-attr >>> once per file is very slow. With this patch gitk does attribute >>> lookup in batches of 30 files while reading the diff file list, >>> which leads to a very noticeable speedup. >> This one does not work for me: The correct is not picked up anymore, >> neither in Patch mode nor Tree mode. (It works as expected without this >> patch.) >> > > OOPS, I forgot to copy the line that removes leading whitespace: Thanks, with this it works now. The delay for a 1000 file patch is bearable (on Windows, but y'know, Windows types are masochists :-). Feel free to add: Tested-by: Johannes Sixt <johannes.sixt@xxxxxxxxxx> to the patches in the series when you resend it - and I hope you do resend it after addressing Paul's concerns. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html