Boyd Lynn Gerber wrote: > So on these patches, > What do you want me to do? I applied them and things kinda worked. Test t4018-diff-funcname.sh should pass. As Johan mentioned, in the last patch '\\s' should have been converted to '[ \t]', rather than to just ' ', but that should not affect the test and should only affect html, python, and ruby patterns. It would be nice if the tests were expanded. > The > problem is pine/alpine messes them up a bit and it is not easy to > manually fix them. It would be easier to git clone/pull them from > either a site or the trees. I expect they will be in Junio's tree soon, most likely the master branch. >I do think that on some we should use the > actual charact vers the C-syntax. "\t" for example. "\t" is safe to use since it is interpreted by git in config.c: parse_value(), not by the regex library. I was also concerned about that character until I traced the code to parse_value(). Junio is right that better documentation of this feature is needed. -brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
