Re: [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan del Strother wrote:
> On Thu, Sep 18, 2008 at 1:21 AM, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote:
>> Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx>
>> ---
>>
>>
>> This is a blind conversion removing \\ before ( and { etc.
>> and adding \\ before naked ( and { etc.
>>
>> I hope the authors who last touched these patterns will help with testing:
> 
> 
> None of the patterns using \\s seem to work for me.  I had to replace
> them with [ \t] - is this a problem with the darwin regex
> compatibility library or something?  I applied the patches on master
> (97d7fee2cb), and am running OS X 10.5.5.

I was going to say possibly \s is a gnu extension, but if by "compatibility
library", you mean compat/regex/regex.[ch] in the git source which is used
by default now on OSX, then that _is_ the gnu library.

I just tried the ruby pattern on IRIX6.5 and Solaris7 and \\s does not work.
I am not using compat/regex/regex.[ch]. Same pattern works on linux.

Looks like '\\s' needs to be changed to ' '.

-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux