Joey Hess <joey@xxxxxxxxxxx> writes:
> Subject: [PATCH] avoid gitweb uninitialized value warning
I would say _where_ this uninitialized value warning was, e.g.
Subject: [PATCH] gitweb: avoid warnings for commits with no body
>
> In the ususual case when there is no commit message, gitweb would
> output an uninitialized value warning.
Typo: s/ususual/unusual/
>
> Signed-off-by: Joey Hess <joey@xxxxxxxxxxx>
Acked-by: Jakub Narebski <jnareb@xxxxxxxxx>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 29e2156..da474d0 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2123,7 +2123,7 @@ sub parse_commit_text {
> last;
> }
> }
> - if ($co{'title'} eq "") {
> + if (! defined $co{'title'} || $co{'title'} eq "") {
I would avoid space between logical negation operator '!' and
its operand, i.e. I would write:
+ if (!defined $co{'title'} || $co{'title'} eq "") {
> $co{'title'} = $co{'title_short'} = '(no commit message)';
> }
> # remove added spaces
> --
> 1.5.6.5
>
> --
> see shy jo
--
Jakub Narebski
Poland
ShadeHawk on #git
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
