Re: [RFC/PATCH] Use compatibility regex library for OSX/Darwin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 16 Sep 2008, Jeff King wrote:
On Tue, Sep 16, 2008 at 05:25:46PM -0600, Boyd Lynn Gerber wrote:
I wonder if this is the right fix? Right now the GNU regex library is
necessary for Darwin, FreeBSD and AIX. I can add IRIX6.5 and Solaris 7
to that list. Have newer Solaris's been tested yet? (Jeff?) I wonder if
the new test which triggers this flaw has been tested on the other
non-GNU platforms in the Makefile which have not been updated. Boyd
Lynn Gerber and his 12 platforms comes to mind.

Someone forwarded me this email and asked if I had tested it.  I have not.
Where is the easiest place to get it to test with the various platforms?
I will check it out on 3-5 of them.  I now have 1.6.0.2 on 5 platforms
running and working.  I have not had the time to get it on the other's
yet.

The problematic test is in 1.6.0.2; if you can run t4018-diff-funcname
successfully, then I believe you are not affected.

When I do a gmake test these 4 platforms all fail only these 2 tests.

* FAIL 10: reinit


                (
                        unset GIT_CONFIG GIT_WORK_TREE GIT_CONFIG

                        mkdir again &&
                        cd again &&
                        git init >out1 2>err1 &&
                        git init >out2 2>err2
                ) &&
                grep "Initialized empty" again/out1 &&
                grep "Reinitialized existing" again/out2 &&
                >again/empty &&
                test_cmp again/empty again/err1 &&
                test_cmp again/empty again/err2

* FAIL 11: init with --template

                mkdir template-source &&
                echo content >template-source/file &&
                (
                        mkdir template-custom &&
                        cd template-custom &&
                        git init --template=../template-source
                ) &&
                test_cmp template-source/file template-custom/.git/file

*   ok 12: init with --template (blank)
* failed 2 among 12 test(s)
gmake[1]: *** [t0001-init.sh] Error 1
gmake[1]: Leaving directory `/home/zenez/build/osr6/git-1.6.0.2/t'
gmake: *** [test] Error 2

I have not had time to look into the failures. How many tests should I see and pass. The first 40 all pass. Then 2 of 12 fail as above.

--
Boyd Gerber <gerberb@xxxxxxxxx>
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux