Hello,
----- Original Message ----
> From: Jing Xue <jingxue@xxxxxxxxxxxxxxxxx>
> To: David Brown <git@xxxxxxxxxx>
> Cc: Daniel Barkalow <barkalow@xxxxxxxxxxxx>; Junio C Hamano <gitster@xxxxxxxxx>; dhruva <dhruva@xxxxxxxxx>; GIT SCM <git@xxxxxxxxxxxxxxx>; Simon Hausmann <simon@xxxxxx>
> Sent: Tuesday, 16 September, 2008 6:28:56 PM
> Subject: Re: [PATCH] Optional shrinking of RCS keywords in git-p4
>
> On Mon, Sep 15, 2008 at 09:12:01PM -0700, David Brown wrote:
> > A simple way to be paranoid would be something (shell-ish) like:
> >
> > p4 print filename | collapse-keywords | git hash-object --stdin
> >
>
> How about collapsing the keywords in the _p4_ version after "p4 edit"
> but before applying the patch, and just "p4 submit" the collapsed
> version if patching succeeds? As pointed out earlier in this thread, p4
> submit doesn't care about whether keywords are expanded or not anyway.
That is feasible but would require more changes. I still feel having an option to disable the keyword from collapsing is a move forward followed by your suggestion as a bug fix to fix the issue with 'p4 submit' when rcs keywords are collapsed. Would that be an acceptable approach?
-dhruva
Unlimited freedom, unlimited storage. Get it now, on http://help.yahoo.com/l/in/yahoo/mail/yahoomail/tools/tools-08.html/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
