> profile_unzip=PROFILE_UNZIP_${profile} > profile_zip=PROFILE_ZIP_${profile} > UNZIP_OPTS=${!profile_unzip} > ZIP_OPTS=${!profile_zip} Can be written (in pure bourne shell) as eval UNZIP_OPTS=\$PROFILE_UNZIP_${profile} eval ZIP_OPTS=\$PROFILE_ZIP_${profile} > --unzip_opts) > UNZIP_OPTS=${UNZIP_OPTS} $2 Missing quotes: UNZIP_OPTS="${UNZIP_OPTS} $2" It could also be a good idea to do UNZIP_OPTS="${UNZIP_OPTS} `echo $2 | sed 'y/,/ /' `" (compare with the -Wa/-Wl/-Wp options of gcc) so you can do [filter "opendocument"] clean = "rezip --unzip-opts -b,-qq,-X --zip-opts -q,-r,-D,-0" smudge = "rezip --unzip-opts -b,-qq,-X --zip-opts -q,-r,-D,-6" And maybe -b,-qq,-X and -q,-r respectively could be added by default? Anyway, nice script, thanks! Paolo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html