David Brown <git@xxxxxxxxxx> writes: > ... As far as I can tell, P4 completely > ignores whatever the $Id: ...$ headers happen to be expanded to at the > time of checking. You can put garbage there, and it check in fine. > ... > I guess it isn't a problem to make this optional in git-p4, but I > don't think this patch is solving the right problem. Hmm. I do not do p4, but what I am guessing is that there probably is a configuration switch on the p4 side that lets you check in files with "$Id: garbage $" in them, while dhruva hasn't turned that switch on. It could be (1) not flipping the switch on is a user mistake and dhruva can just flip it to fix his problem, or (2) the policy of dhruva's project mandates the switch to stay off, and he needs the patch to work around the issue. I cannot judge which is the case myself, but if the situation is the former, we would need a documentation to suggest that magic p4 switch as a workaround that would work for everybody without hurting anybody. On the other hadn, if the situation is the latter, we would need this patch in addition to the suggestion of the magic p4 switch that the user _may_ be able to flip depending on the project policy on the p4 side. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
