Re: [PATCH] Optional shrinking of RCS keywords in git-p4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,



----- Original Message ----
> From: Junio C Hamano <gitster@xxxxxxxxx>
> To: Dhruva Krishnamurthy <dhruva@xxxxxxxxx>
> Cc: GIT SCM <git@xxxxxxxxxxxxxxx>
> Sent: Monday, 15 September, 2008 11:47:19 AM
> Subject: Re: [PATCH] Optional shrinking of RCS keywords in git-p4
> 
> Dhruva Krishnamurthy writes:
> 
> > Modifying RCS keywords prevents submitting to p4 from git due to missing 
> hunks.
> 
> Hmm.  How are "missing hunks" caused?  Do you mean:
> 
> - the substituted values from the expanded keywords are stripped out by
>    default (with kwstrip=True) when you check out from p4;
> 
> - when you submit your changes back, p4 side expects you to send the file
>    with keywords just as it originally expanded;
> 
> and this causes the contents mismatch, leading p4 to reject your change?

Yes (you got my point ;), I have quite often stumbled in conveying things in a crisp manner (on going learning process)

> The patch itself looks fine; I just wanted to make sure commit log
> explains what was fixed.

-dhruva



      Unlimited freedom, unlimited storage. Get it now, on http://help.yahoo.com/l/in/yahoo/mail/yahoomail/tools/tools-08.html/

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux