Junio C Hamano <gitster@xxxxxxxxx> writes: >> +{ >> + char *key = submodule_by_path(name); >> + char *sectend = strrchr(key, '.'); >> + >> + assert(sectend); >> + *sectend = 0; > > Here is one caller I questioned in my comments on [1/6]... Another thing --- can submodule_by_path() ever return NULL saying "I do not see one in the configuration"? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html