Hi, Junio. Thanks for the provided patch. It works fine for me and I agree that it is better do not hardcode that only hooks are executable. So your solution looks better for me. +1 for include this patch. Now permissions for are anatol:repo $ ls -l /usr/share/git-core/templates/ -R /usr/share/git-core/templates/: total 16 drwxr-xr-x 2 root root 4096 2008-09-11 10:13 branches -rw-r--r-- 1 root root 58 2008-09-11 10:13 description drwxr-xr-x 2 root root 4096 2008-09-11 10:13 hooks drwxr-xr-x 2 root root 4096 2008-09-11 10:13 info /usr/share/git-core/templates/branches: total 0 /usr/share/git-core/templates/hooks: total 44 -rwxr-xr-x 1 root root 452 2008-09-11 10:13 applypatch-msg.sample -rwxr-xr-x 1 root root 894 2008-09-11 10:13 commit-msg.sample -rwxr-xr-x 1 root root 160 2008-09-11 10:13 post-commit.sample -rwxr-xr-x 1 root root 553 2008-09-11 10:13 post-receive.sample -rwxr-xr-x 1 root root 189 2008-09-11 10:13 post-update.sample -rwxr-xr-x 1 root root 398 2008-09-11 10:13 pre-applypatch.sample -rwxr-xr-x 1 root root 519 2008-09-11 10:13 pre-commit.sample -rwxr-xr-x 1 root root 1219 2008-09-11 10:13 prepare-commit-msg.sample -rwxr-xr-x 1 root root 4942 2008-09-11 10:13 pre-rebase.sample -rwxr-xr-x 1 root root 2892 2008-09-11 10:13 update.sample /usr/share/git-core/templates/info: total 4 -rw-r--r-- 1 root root 240 2008-09-11 10:13 exclude On Tue, Sep 9, 2008 at 1:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Didn't 9907721 (templates/Makefile: don't depend on local umask setting, >> 2008-02-28) take care of that? >> >> ... goes and looks ... >> >> Ah, that is only to propagate the wish of the person who _built_ it. >> >> You probably have a tight umask and have sources checked out unreadable to >> others, which is propagated to the installation (check the permission of >> files in your templates/blt directory to verify this conjecture). And the >> build procedure is honoring your wish to make things unreadable to others. > > I should have said "too tight a umask", but anyway, try this patch and see > it helps. > > -- >8 -- > Fix permission bits on sources checked out with an overtight umask > > Two patches 9907721 (templates/Makefile: don't depend on local umask > setting, 2008-02-28) and 96cda0b (templates/Makefile: install is > unnecessary, just use mkdir -p, 2008-08-21) tried to prevent an overtight > umask the builder/installer might have from screwing over the installation > procedure, but we forgot there was another source of trouble. If the > person who checked out the source tree had an overtight umask, it will > leak out to the built products, which is propagated to the installation > destination. > > templates/Makefile | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git c/templates/Makefile w/templates/Makefile > index 0722a92..a12c6e2 100644 > --- c/templates/Makefile > +++ w/templates/Makefile > @@ -31,9 +31,11 @@ boilerplates.made : $(bpsrc) > dir=`expr "$$dst" : '\(.*\)/'` && \ > mkdir -p blt/$$dir && \ > case "$$boilerplate" in \ > - *--) ;; \ > - *) cp -p $$boilerplate blt/$$dst ;; \ > - esac || exit; \ > + *--) continue;; \ > + esac && \ > + cp $$boilerplate blt/$$dst && \ > + if test -x "blt/$$dst"; then rx=rx; else rx=r; fi && \ > + chmod a+$$rx "blt/$$dst" || exit; \ > done && \ > date >$@ > > -- anatol -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
