Jeff King <peff@xxxxxxxx> writes: > On Wed, Sep 10, 2008 at 01:41:06AM +0200, Miklos Vajna wrote: > >> test_expect_success \ >> 'validate git-rev-list output.' \ >> - 'diff current expected' >> + 'test_cmp current expected' > > We seem to use the convention of > > test_cmp <expected> <actual> > > elsewhere, rather than > > test_cmp <actual> <expected> > > as you have here. Most noticeably, that means the diff will show > deviations from expected, rather "what should be done to make this as > expected". Yes, please. I am glad to see somebody noticed it (I've been fixing these whenever I touched vicinity of the ones that had comparisons swapped). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
