Nanako Shiraishi <nanako3@xxxxxxxxxxx> writes: > The environment variable CVS_SERVER is still set to "git-cvsserver", > because tests fail with CVS_SERVER='git cvsserver' (or double quotes). My eyes are getting dry after looking at these s/git-/git / patches, so please do not get offended if I leave these in my Inbox unread for a few days. But I think this particular one is worth mentioning something about, so I am responding to it now. To me, the above suggests that: * we should install git-cvsserver in $(bindir) so that it can be found on $PATH; and * it would be better to encourage users to consistently use "git-cvsserver" everywhere instead of "git cvsserver"; hence * this [6/6] in the series should be discarded. We already install "server side programs" in $(bindir). When we think about any of these server side programs, we do not think of it as a feature chosen by the subcommand word on the command line given to a program "git" (even though for built-ins, internal implementation might allow such usage). Instead we think of it as a single freestanding program in git suite. For example, when people talk about "You can use git-shell as your user's login shell to limit the potential damage to your system", they do not mean "the shell subcommand of git", but they mean the git-shell "program". We do not run "git in daemon mode", but run "git-daemon" which is the daemon program that serves native git protocol. So why don't we do this (not just for test but for documentation as well)? * We do not use "git foo" form when refering to the "server side programs". Make it official; * We move "server side programs" in git(7) documentation into its separate subsection; and * We always install "server side programs" in $(bindir). I think git-cvsserver is the last one we missed from the set of server side programs (git-cvsserver, git-daemon, git-receive-pack, git-upload-archive, git-upload-pack). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
