Re: Revert behavior [Was: Re: [ANNOUNCE] yap: Yet Another (Git) Porcelain]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 9, 2008 at 8:38 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> Elijah Newren wrote:
>> On Mon, Sep 8, 2008 at 10:25 PM, Govind Salinas
>> <govind@xxxxxxxxxxxxxxxxx> wrote:
>> > On Mon, Sep 8, 2008 at 8:05 PM, Steven Walter <stevenrwalter@xxxxxxxxx> wrote:
>>
>> > I had some very different ideas along the lines of reducing the number of
>> > commands (where the commands do something similar just DWIM rather
>> > than force me to remember or read docs on different commands), making
>> > commands look similar to commands from other SCMs (revert should do
>> > what it does for me in all the other SCMs that I have used, which is to
>> > checkout the HEAD copy into the working directory)
>>
>> Your description of revert in various systems isn't quite accurate; it
>> isn't necessarily HEAD, since most systems (at least bzr and hg) can
>> also revert files to revisions earlier than HEAD.  In fact, questions
>> of how to do that have come up several times on this list, so you
>> wouldn't want to exclude that case.  Also, the revert behavior of git
>> (minus perhaps the default auto-commit) comes in pretty handy too
>> sometimes, and I can't easily find it in other systems (I suspect many
>> just drop back to diff + patch to handle the case that git provides).
> [...]
>
> By the way, I think the fact that in different SCMs meaning of
> "$scm revert" and of "$scm reset" differs widely caused Mercurial
> to adopt "hg backout" for creating a commit which reverts changes
> (cherry-pick -R), and "hg rollback" to undo last commit.
>

My take on this comes from my own personal experience with "revert"
commands, the fact that "how do i undo my working dir changes" is
the most common question I see on the list and that I have heard
others with the same complaint.

I will concede that revert usually means both "discard current working
dir changes" and "undo a previous change" in different circumstances.
However, the number of times that "how do i discard my working
dir changes" comes up on the list leads me to believe that you get
the most out of using revert for this, since it is something that should
be familiar to a user and undoing a previous commit is more rare.

Of course, this is where I would use a DWIM-ism.
"pyt revert -r commitish" would generate a reverse patch but
"pyt revert <paths>..." would checkout from HEAD.  "pyt revert" would
just "git reset --hard".

-Govind
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux