Re: [PATCH] Use GIT_COMMITTER_IDENT instead of hardcoded values in import-tars.perl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 7 Sep 2008, Mike Hommey wrote:

> -my $committer_name = 'T Ar Creator';
> -my $committer_email = 'tar@xxxxxxxxxxx';
> +chomp(my $committer_ident = `git var GIT_COMMITTER_IDENT`);
> +die 'You need to set user name and email'
> +	unless ($committer_ident =~ s/(.+ <[^>]+>).*/\1/);

I have at least one script that will be broken by this change in behavior.

To me, the issue is just like git-cvsimport, which sets the committer not 
to the actual committer, so that two people can end up with identical 
commit names, even if they cvsimported independently.  I'd like the same 
behavior for import-tars.  I actually use it that way.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux