Abhijit Menon-Sen <ams@xxxxxxxxxx> wrote: > At 2008-09-08 19:02:05 +0900, nanako3@xxxxxxxxxxx wrote: > > > > This first step replaces literal strings "remotes/git-svn" and > > "git-svn-id" by introducing $remotes_git_svn and $git_svn_id > > constants defined as shell variables. > > I'm sorry, but... why? I don't see the point at all. These are not even > commands; and, as someone who was just reading the svn tests, the change > certainly doesn't make them *easier* to follow. They'll show up as false positives when grepping for "git-" The commit message should've mentioned that, though (assuming I'm reading Nanako's mind correctly :) Nanako: I'm fine with the patches, too sleepy and tired to actually test them, though. -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
