Re: [PATCH] Teach "log -F --author=<match>" to behave better

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 04, 2008 at 01:31:19AM -0700, Junio C Hamano wrote:
> To handle --author=<match> request, the code created a grep instruction
> that tried to match a line that begins with 'author ' and <match>
> somewhere on the same line.  "begins with 'author '" obviously needs to be
> expressed with an regexp '^author '.
> 
> When the user specifies --fixed-string, this does not work at all.
> 
> This extends the grep machinery so that a match insn can ignore user
> specified --fixed-string request, and uses the '( -e A --and -e B )'
> construct from the grep machinery in order to express "has to begin with
> '^author ', and also the same line must match the given pattern".
> 
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>

Wow, this is clever solution! FWIW,

Acked-by: Petr Baudis <pasky@xxxxxxx>

There goes one of my long-standing TODO items. :-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux