Re: [PATCH/resend] Fix use of hardlinks in "make install"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Am 30.08.2008 um 02:20 schrieb Alex Riesen:

The code failed to filter-out git-add properly on platforms were $X is
not empty (ATM there is only one such a platform).

Than it tried to create a hardlink to the file ($execdir/git-add) it just
removed (because git-add is first in the BUILT_INS), so ln failed (but
because stderr was redirected into /dev/null the error was never seen), and
the whole install ended up using "ln -s" instead.

Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx>
---

Well, as usual, simple fix for a trivial typo caused by existence of an
idiotic platform.

Makefile |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index bf400e6..20f028f 100644
--- a/Makefile
+++ b/Makefile
@@ -1379,7 +1379,7 @@ endif
	{ $(RM) "$$execdir/git-add$X" && \
		ln git-add$X "$$execdir/git-add$X" 2>/dev/null || \
		cp git-add$X "$$execdir/git-add$X"; } && \
- { $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) "$$execdir/ $p" && \ + { $(foreach p,$(filter-out git-add$X,$(BUILT_INS)), $(RM) "$ $execdir/$p" && \
		ln "$$execdir/git-add$X" "$$execdir/$p" 2>/dev/null || \
		ln -s "git-add$X" "$$execdir/$p" 2>/dev/null || \
		cp "$$execdir/git-add$X" "$$execdir/$p" || exit;) } && \
--
1.6.0.1.152.g6969c

Your patch seems to work on Haiku, don't have a MinGW setup to test. Sorry for the breakage.

Andreas

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux