Brandon Casey wrote: > The following syntax: > > char foo[] = { > [0] = 1, > [7] = 2, > [15] = 3 > }; > > is a c99 construct which some compilers do not support even though they > support other c99 constructs. This construct can be avoided by folding > these 'special' test cases into the sane_ctype array and making use of > the related infrastructure. You probably would want to squash this in: diff --git a/dir.c b/dir.c index e6a2556..acf1001 100644 --- a/dir.c +++ b/dir.c @@ -52,11 +52,6 @@ int common_prefix(const char **pathspec) return prefix; } -static inline int special_char(unsigned char c1) -{ - return !c1 || c1 == '*' || c1 == '[' || c1 == '?' || c1 == '\\'; -} - /* * Does 'match' matches the given name? * A match is found if @@ -80,7 +75,7 @@ static int match_one(const char *match, const char *name, int for (;;) { unsigned char c1 = *match; unsigned char c2 = *name; - if (special_char(c1)) + if (isspecial(c1)) break; if (c1 != c2) return 0; -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html