Marek Zawirski <marek.zawirski@xxxxxxxxx> wrote:
> Shawn O. Pearce wrote:
>> diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/DefaultSshSessionFactory.java b/org.spearce.jgit/src/org/spearce/jgit/transport/DefaultSshSessionFactory.java
> (...)
>> + try {
>> + addIdentity(k);
>> + } catch (JSchException e) {
>> + if (e.getMessage().startsWith("invalid privatekey: "))
>> + continue;
>> + throw e;
>> + }
>
> That's extreme error handling with JSch;) Do you really think it's
> better to rely on internal error message instead of continuing in any
> case? Which other exceptions we would like to pass level up?
Oh, that's a good question. In this particular code we're just
trying to prime the list of known keys so there's a chance we could
later prompt you for a passphrase during the handshaking. So we
probably could get away with just ignoring all JSchExceptions at
this stage and treat the key as though it wasn't present...
I can't imagine what else we'd get back. A FileNotFoundException
just means the user deleted the key before we could actually read
it (no big deal); an IOException because the key isn't readable
isn't an issue either.
I guess I can just change this to ignore everything.
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
