Re: [PATCH] t9700-perl-git.sh: Fix a test failure on cygwin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> writes:

> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>
> ---
>
> This patch fixes the t9700 test failure on cygwin. Don't ask me to
> explain why the original test.pl fails on cygwin, but passes on Linux!
>
> My perl version:
>
>     $ perl --version
>
>     This is perl, v5.8.7 built for cygwin-thread-multi-64int
>     (with 1 registered patch, see perl -V for more detail)
>
>     Copyright 1987-2005, Larry Wall
>
>     Perl may be copied only under the terms of either the Artistic License or the
>     GNU General Public License, which may be found in the Perl 5 source kit.
>
>     Complete documentation for Perl, including FAQ lists, should be found on
>     this system using `man perl' or `perldoc perl'.  If you have access to the
>     Internet, point your browser at http://www.perl.org/, the Perl Home Page.
>     $ 
>
> [My perl version on Linux is whatever comes with Ubuntu 7.04]

Curious.

What does this give you:

	$ cd t
        $ sh t9700-perl-git.sh -v

with the attached patch?  Unfortunately this cannot be run with "-i -v"
because 'test_external_without_stderr' uses test_external which in turn
exits upon failure when -i is given, without letting the former to report
what was given to the standard error stream (this is slightly offtopic but
pertains to debuggability of tests, so Lea is Cc'ed).

For me, cwd() is the same as Cwd->cwd (this is from Perl 5.8.8); perhaps
it behaves differently on Cygwin?

 t/t9700/test.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git i/t/t9700/test.pl w/t/t9700/test.pl
index 851cea4..139711d 100755
--- i/t/t9700/test.pl
+++ w/t/t9700/test.pl
@@ -15,6 +15,12 @@ BEGIN { use_ok('Git') }
 
 # set up
 our $abs_repo_dir = Cwd->cwd;
+our $cwd = cwd();
+print STDERR "Cwd->cwd says '$abs_repo_dir'\n";
+print STDERR "cwd() says '$cwd'\n";
+
+exit(1);
+
 ok(our $r = Git->repository(Directory => "."), "open repository");
 
 # config
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux