David Soria Parra <sn_@xxxxxxx> writes: > From: David Soria Parra <dsp@xxxxxxx> > > Constants that have the names of CPU registers are already defined > in OpenSolaris's sys/regset.h. This causes a warning as we try to > (re)define SS in ctype.c. So we just use another name. I do not mind this _particular_ workaround per-se, but I have to wonder what happens the next time some random other platform has "SP" defined in a random header file. First of all, why are you including <sys/regset.h>? We certainly don't include from any of our header or source files. And second of all, why is the indirect inclusion of that header file by some standard header file we do include cause the namespace to get poluted with "SS" symbol? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html