Actually, I only wanted to do 5/6 (git svn info: make info relative to the current directory). This seemed like a fairly simple change, see the corresponding mail. However, I also wanted to provide tests, and that's where the fun started. Turns out t9119-git-svn-info.sh is currently quite broken. 1-4 just fix the tests; a brief summary: [1/6] git svn info: tests: let 'init' test run with SVN 1.5 The tests do not report any problems with 1.5. [2/6] git svn info: tests: do not use set -e No idea how 'set -e' ever got in there; it completely breaks the test script in case of an error. [3/6] git svn info: tests: use test_cmp instead of git-diff git-diff does not correctly report the exit status (IIRC that is caused by the pager setup code?), which used to hide a lot of errors. [4/6] git svn info: tests: fix ptouch argument order in setup Swapped arguments caused ptouch to fail and tests to break. Yes, I'm just whoring commit karma here, so feel free to squash these four into one if you like it better that way. After these, 22 of 37 tests (all except --url, plus all unknown files) fail. Most of them are caused by 'git svn info' not URL-encoding the URL and Repository fields in the output, as SVN does. 6/6 fixes this. However, the unknown files tests still fail, simply because 'svn info' itself fails on untracked files. It would be great if someone who is still running SVN 1.4 could check whether that has been a bug in git-svn all along, or is actually a behaviour change on the part of SVN. Oh, and let's hope I did the splitting right this time :-) git-svn.perl | 30 +++++++++++-- t/t9119-git-svn-info.sh | 102 ++++++++++++++++++++++++++--------------------- 2 files changed, 82 insertions(+), 50 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
