"Stephen R. van den Berg" <srb@xxxxxxx> writes: > Junio C Hamano wrote: > ... >>It seems that kill_some_child() will not kill anything if nobody else is >>coming from the same address, while the old code did kill some. Is this >>intended? > > This is intended. > ... >>... If you >>simplify add_child() to queue the newborn always at the front of the list, >>your kill_some_child() will continue to do so, so I do not see the point >>of the loop in add_child(). Am I mistaken? > ... > You are mistaken. > The point is that we need to find out *duplicate* IP-adresses. Lightbulb goes on on both counts. Thanks. > Shall I incorporate your suggested changes (as far as I consider them ok) > into my patches and resubmit them? I think your response makes the only remaining is the style fixup, which was my [1/3] from yesterday, so I think we are Ok with what already we have. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
