Re: [PATCH v5] gitweb: ref markers link to named shortlogs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> On Mon, 25 Aug 2008, Junio C Hamano wrote:
>> Jakub Narebski <jnareb@xxxxxxxxx> writes:
>> 
>> > +                     $markers .= " <span class=\"$class\" title=\"$ref\">" .
>> > +                             $cgi->a({-href => href(action=>( $indirect ? "tag" : "shortlog"),
>> > +                                                    hash=>"refs/$ref")}, $name) .
>> > +                             "</span>";
>> >
>> > or equivalent (not stripping "refs/" in git_get_references).
>> 
>> If you mean by "hash => $it", I think it is only used as the URL the
>> anchor points at, and it is much more preferable to use the canonical
>> form.  "...?h=refs/heads/master" and "...h=heads/master" might produce the
>> same output, but then it is better for smart caching layer if you always
>> used canonical form, isn't it?
>
> Will you do the change, or do you need resend from Giuseppe?
>
> I like the feature that this patch introduces, and this time I don't
> have any reservations to the code. So, FWIW, Ack from me.

I could do it, but my preference is for somebody I trust to resend with
appropriate Ack lines so that I can just run "git am" on the message
without editing.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux