Re: [bug] Segfault in git rev-list --first-parent --bisect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> "Avery Pennarun" <apenwarr@xxxxxxxxx> writes:
>
>>     $ git rev-list --first-parent --bisect 5109c91 ^d798a2bfe094
>>     Segmentation fault
>
> Totally untested, usefulness fairly unknown.

The latter part of this statement needs a bit of explanation.  I do not
mean "--first-parent --bisect" is useless.  What I meant is that the
approach is only catering to --first-parent and not about non-standard way
to limit the list such as --since, --max-count, etc.

The current bisection algorithm only pays attention to the pathspec based
history simplification and bottom..top (aka "UNINTERESTING or not").  A
proper fix to handle these cases should work inside do_find_bisection(),
and count_interesting_parents() instead of hiding the parents away that
first_parent traversal did not touch, like the patch I sent out.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux