On Fri, Aug 22, 2008 at 3:01 PM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
>
> Seems overly complicated. How about something like this, instead?
> It simply moves stripping ^{} from refs to format_ref_marker(),
> and uses "tags/v1.5.0^{}" instead of [ "tags/v1.5.0", 1 ].
My thought was that if the refs stuff was being used for something
else than format_ref_marker, it would fail more spectacularly due to
the different kind of values, rather than introducing potentially
subtle bugs due to the additiona ^{} popping in unexpectedly, but it
wouldn't be a problem to do it the simple way. Let me clean the patch
up and resubmit it.
--
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
