Boaz Stuller <boazstuller@xxxxxxxxx> wrote: > On Wed, Aug 20, 2008 at 4:11 AM, Eric Wong <normalperson@xxxxxxxx> wrote: > > Boaz Stuller <boazstuller@xxxxxxxxx> wrote: > >> I'm having a problem with git-svn. I was connecting to a remote svn > >> repository via the svn+ssh:// protocol using an embedded username in > >> the url, i.e svn+ssh://boazstuller@xxxxxxxxxxxxxxx/some/complicated/path. > >> When I upgraded to 1.6.0, 'git svn dcommit' stopped working and > >> instead kept asking me for a password. I tracked the problem down to > >> the following commit: > >> > >> commit ba24e7457aa1f958370bbb67dfb97e3ec806fd4a > >> Author: Eric Wong <normalperson@xxxxxxxx> > >> Date: Thu Aug 7 02:06:16 2008 -0700 > >> git-svn: add ability to specify --commit-url for dcommit > >> > >> I don't know perl, but the problem seems to be where around line 446, > >> '$gs->full_url' gets changed to '$url'. Apparently, $gs->full_url > >> contained the embedded username but $url has it stripped out, i.e > >> svn+ssh://svn.example.com/some/complicated/path , so ssh can't tell > >> what username I'm trying to log in as. > > > > Hi Boaz, thanks for tracking this down. The following patch should > > fix your issue (and another potential one I noticed). > > > > I've lightly tested it and it appears to work for me. > > I only tested with a couple commits too, but your patch works > perfectly for me. Junio: please apply my patch to maint, thank you. -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
