Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@xxxxxxxxx> wrote:
> Marcus Griep wrote:
>> It looks like an empty line added to the end of the file.
>> Unsanitary, but ok since it comes after the last MIME
>> multipart boundary.  Junio could probably just ax the change
>> to sample.mbox from the patch before applying it.

No the change was intentional.  In fact, because that extra line was
not there, a bug was hidden.  Adding the extra line exposed the bug
and hopefully will catch any more bugs in the future with regards to
the boundary code.

>
> Or I could have misunderstood the intent of the change, and it
> is necessary to fully test the change, since it appears to
> operate line-by-line, an empty line at the end would be necessary
> to trigger the code path that stops mailinfo from looking for
> another boundary.

Yes, exactly.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux