Re: [EGIT PATCH 00/31] Push GUI, GUI improvements, various jgit stuff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robin Rosenberg wrote:
tisdagen den 19 augusti 2008 19.59.31 skrev Shawn O. Pearce:
Marek Zawirski <marek.zawirski@xxxxxxxxx> wrote:
Robin, Tor, I know that you were already contributing some graphics to
egit. If someone of you would like to do some icon for push/fetch with
pleasure, you are welcome. Otherwise I'll have to do some crappy icon
instead ;) Another matter are checkboxes screenshots. I'm not sure
about legality status of including them. Any ideas if/how we co use
them or some another set that we can for sure?
So my office-mate suggests that the output of a program (in this
case the checkbox icon) isn't covered by the same copyright as the
program that created it. So we may be OK.
It's not that simple. That obviously may be the case, but I'm certain
it does not apply to individual well defined pieces of artwork (or text for
that matter) included in the output.
Or we just use some other sort of icon for the checkbox. Maybe Tor would be able to
come up with something useful here?
Most annoying is that we'd need one (four) for each LAF supported.

Well, consider that they are even more of them. GTK+ has configurable themes (in my case it is delegation to QT with Plastik theme, where screenshot was made). I don't know about other platforms, but always having hyper-UI Mac OS X and Windows Vista may also have some customization options. No matter how icons we would prepare, always there will be somebody who can say that these icons are somehow inconsistent with his/her LAF.

So I think, it'd better to have this mentioned ugly code workaround just for Mac OS (only there flashing window is so annoying). Less people suffering.

Or as Shawn said, we can try to make our own funny icon for Force Update (red "F"-enabled and gray "F"-disabled?) that is equally (in)consistent for everybody.

Anyway, most of this series looks pretty good to me.  I found a
few other annoying bugs in JGit and EGit as a result of testing
this series, but they are unrelated to the series and have been
there all along.  So I may try to fix them in the coming weeks.

Nice testing then, as I have spend hours on testing UI tricks and haven't noticed more bugs;) Beside of some indexing problems in old API.

 55 files changed, 6471 insertions(+), 981 deletions(-)
Heh.  Been busy, hmm?  ;-)

The weather in and around the Baltic Sea has been horrible for much
of August so far. Maybe that helped him. :)

I swear guys, I wasn't sailing for over 1 month;)
Actually, I'm now leaving for few days, so I'm sending out just fixes for issues pointed out by Shawn and found by me in the mean time. I'll squash these patches with existing commits in push branch, as it is probably worth nothing to keep this in history.

Fetch UI and dynamic team menu entries for push and fetch (for configured remotes) are underway, I'll come back to them after coming back home.

BTW, as another developers are getting involved in jgit/egit coding, maybe we could use (update) some wiki page for marking who is working on some topic currently? Now it's not obvious for me, and as we're not so numerous it would be pity to waste our time and do some redundant stuff one day.

--
Marek Zawirski [zawir]
marek.zawirski@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux