Re: [PATCH] t9301-fast-export.sh: don't unset config variable while we're skipping test 4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:
> Brandon Casey <casey@xxxxxxxxxxxxxxx> writes:
> 
>> ---
>>
>>
>> This is necessary if t9301.4 is included in the GIT_SKIP_TESTS
>> environment variable.
> 
> If it is not skipped what happens?  Does your change break this test?

Yes, it was only meant as an example to be used along with the build
script I supplied.

> How about attempting to unset always (because the test does not want to
> have the configuration) but ignore the result from the command (because
> the config may not have had anything to unset to begin with depending on
> what happened in the previous tests)?

Yes, unsetting always and ignoring the result would allow this test to
pass. It could also be moved into its own test so that it could be skipped
using GIT_SKIP_TESTS, but still signal failure when it is not skipped.

-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux