Ahh, looks like it's a grep problem, thanks. opensolaris grep doesn't
like the options in the test.
By default it provides ggrep (gnu grep ) which does have the
appropriate options.
After making some changes so that the right grep is available ( moving
the old one out of the way and symlinking ggrep in place ) the tests
proceed past the original point to here:
* passed all 6 test(s)
*** t0004-unwritable.sh ***
* expecting success:
>file &&
git add file &&
test_tick &&
git commit -m initial &&
echo >file &&
git add file
Created initial commit 1bd44cb: initial
0 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 file
* ok 1: setup
* expecting success:
(
chmod a-w .git/objects .git/objects/?? &&
test_must_fail git write-tree
)
status=$?
chmod 775 .git/objects .git/objects/??
(exit $status)
47d83249b05cf06491633be38ea8637c5b356acc
* FAIL 2: write-tree should notice unwritable repository
(
chmod a-w .git/objects .git/objects/?? &&
test_must_fail git write-tree
)
status=$?
chmod 775 .git/objects .git/objects/??
(exit $status)
gmake[1]: *** [t0004-unwritable.sh] Error 1
gmake[1]: Leaving directory `/root/git-1.5.6.5/t'
gmake: *** [test] Error 2
- Sean
On Aug 17, 2008, at 4:03 PM, Jeff King wrote:
On Sun, Aug 17, 2008 at 08:55:57AM -0400, Sean Brandt wrote:
I'm installing on opensolaris 2008.05 and the tests fail in
t0002-gitfile.sh ( test numbers 2 and 3 ) is this expected/ok?
No, it's not expected nor ok (though it there is a reasonable chance
it
is a portability problem in the test script, and not a real git
breakage).
What does
make test GIT_TEST_OPTS="-v -i"
tell you?
if ! grep -qe "Invalid gitfile format" .err
Just a guess, but I think Solaris grep doesn't understand "-q".
Does the patch below help?
---
diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh
index 4db4ac4..e4970fe 100755
--- a/t/t0002-gitfile.sh
+++ b/t/t0002-gitfile.sh
@@ -32,7 +32,7 @@ test_expect_success 'bad setup: invalid .git file
format' '
echo "git rev-parse accepted an invalid .git file"
false
fi &&
- if ! grep -qe "Invalid gitfile format" .err
+ if ! grep -e "Invalid gitfile format" .err
then
echo "git rev-parse returned wrong error"
false
@@ -46,7 +46,7 @@ test_expect_success 'bad setup: invalid .git file
path' '
echo "git rev-parse accepted an invalid .git file path"
false
fi &&
- if ! grep -qe "Not a git repository" .err
+ if ! grep -e "Not a git repository" .err
then
echo "git rev-parse returned wrong error"
false
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
