Stephan Beyer <s-beyer@xxxxxxx> wrote: > Jakub Narebski wrote: > > Please remember that according to timeline in GSoC 2008 FAQ: > > http://code.google.com/opensource/gsoc/2008/faqs.html#0.1_timeline > > August 18: ~12 noon PDT / 19:00 UTC is "Firm 'pencils down' date." > > (suggested pencils down date was August 11). So you don't have much > > time, and you don't leave much time for review, so I guess evaluation > > would be "done, but nor merged in" or something like that. > > I'm wondering about "and you don't leave much time for review". > A comment on this: > LH (from the Google Open Source Team) clarified that the state of > Aug 18 is not the date where everything should be reviewed and merged > in. It is the date where the (following) evaluation (done by the mentor) > of the code is based on. > > See also > http://groups.google.com/group/google-summer-of-code-announce/browse_thread/thread/df7278c6e027dee1 LH is correct. A student doesn't have to get their code merged just to have a successful project. Perhaps the overall project is in a frozen release candidate period and doesn't want to take _any_ new features until after the release is made. That may be a full month after the "pencils down" date. Suppose even further that the project is on SVN, and has just one branch, /trunk, such that even checking in the student's project could break that release. Clearly you cannot require the student to have their code merged just to pass them. However, I think it is reasonable to require that the student has at least posted their patches for review and discussion, and that the student has made a good-faith effort towards making those patches something the community _might_ accept. IOW it would be good enough that Junio would consider slating it into "pu", even though some final cleanup changes may be necessary. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
