Pieter de Bie wrote: > How about something simple like this? Seems to do the job. > diff --git a/builtin-help.c b/builtin-help.c Are you working on next? Even though I know next is the new master. (master is soooo nearly last week. :-P) I had a slightly different take. Your completion creates a 'k' for gitk, which was suggested earlier in the thread suggested is a bit harder to grok. This promotes 'git?' commands to use 'git?' rather than '?' without affecting things otherwise. --- diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index c0bf7aa..0bb0d79 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -885,7 +885,9 @@ _git_help () return ;; esac - __gitcomp "$(__git_all_commands)" + __gitcomp "$(ls $(./git help man-path)/man?/* | + sed -n -e 's/^.*\/git-\?\(.\{2,\}\)\.[0-9]$/\1/p' \ + -e 's/^.*\/git\(.\)\.[0-9]$/git\1/p')" } _git_init () diff --git a/help.c b/help.c index 3cb1962..d0416e1 100644 --- a/help.c +++ b/help.c @@ -717,6 +717,11 @@ int cmd_help(int argc, const char **argv, const char *prefix) return 0; } + if (!strcmp("man-path", argv[0])) { + printf("%s\n", GIT_MAN_PATH); + return 0; + } + switch (help_format) { case HELP_FORMAT_MAN: show_man_page(argv[0]); --- What do you think, Junio? If it works, I'll make this a normal patch submission. -- Marcus Griep GPG Key ID: 0x5E968152 —— http://www.boohaunt.net את.ψο´ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html