Hi, On Wed, 13 Aug 2008, Junio C Hamano wrote: > "Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: > > > Marcus Griep <marcus@xxxxxxxx> wrote: > >> diff --git a/Documentation/git-count-objects.txt b/Documentation/git-count-objects.txt > >> index 75a8da1..291bc5e 100644 > >> --- a/Documentation/git-count-objects.txt > >> +++ b/Documentation/git-count-objects.txt > >> +++ b/builtin-count-objects.c > > ... > >> +void human_readable_size(char *buf, int buf_size, double size /* in bytes */) > > > > Hmm. This probably should be static. Or if it really is meant > > to be a utility for use elsewhere in Git, moved to someplace where > > string handling is done. Its not strbuf related, but maybe strbuf.c > > is a better location for this sort of library function. > > Yes, with customizable precision (so that the caller can control "1.6k" vs > "1.62k"), and perhaps cutomizable unit (so that you can use this for > "3.6kB" and "2.6Mbps"), this kind of thing is a good candidate to be a > library function in strbuf.c. Or, should it ever be merged into git.git, the strbuf_vaddf() routine I wrote. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
