Eric Wong wrote:
> The above is dead code now that we're using the versions in Git::,
> right?
>
> Why create a temporary variable? (and break the sacred 80-column limit).
My cherry-picking & squashing skills are not yet up to snuff. The dead
code and unnecessary variable have now been removed.
> I missed this before, but $tmp_fh->filename doesn't interpolate correctly.
>
> ("write ${\$tmp_fh->filename}: $!\n")
> or
> ("write ", $tmp_fh->filename, ": $!\n") works.
>
> I believe the latter form is more idiomatic so we should probably use
> that...
Done, in the latter form, and fixed in a couple other places.
--
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
