On Mon, Aug 11, 2008 at 8:59 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > >> Petr Baudis schrieb: >>> On Mon, Aug 11, 2008 at 04:59:32PM +0100, Reece Dunn wrote: >>>>>> On Mon, 11 Aug 2008, Francis Moreau wrote: >>>>>>> case "$(read yesno)" in [Nn]*) exit 1 ;; esac >>>> does not work as expected. Replacing this with >>>> >>>> case "$(read yesno; echo $yesno)" in [Nn]*) exit 1 ;; esac >>>> >>>> would work as intended, as Mikael has pointed out. >>> >>> Wouldn't it be more elegant to >>> >>> case "$(head -n 1)" in [Nn]*) exit 1 ;; esac >> >> Only if head is a built-in, otherwise you fork needlessly. Not that >> this is a performance critical part, but I wouldn't call it "elegant". >> >> What's wrong with the following variant, already used a few lines up in >> the file? >> >> read yesno >> case "$yesno" in [Nn]*) exit 1 ;; esac > > That's the right way to spell it. Sorry, I must have been too tired > when I did this. > > > I sent a patch to fix that way already Cheers. -- Francis -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
