Hi, This series of patches refactors a few function calls into git-p4 so that they all go via the same function to build up the command line. It also then allows users to specify any particular user / password required to access their Perforce repository (plus a few other parameters). I have specifically tested this agains the public Zimbra repository and it works for me fine. Any feedback would be welcomed. Thanks, Anand Anand Kumria (12): Create a specific version of the read_pipe_lines command for p4 invocations Utilise the new 'p4_read_pipe_lines' command Have a command that specifically invokes 'p4' (via system) Utilise the new 'p4_system' function. Add a single command that will be used to construct the 'p4' command If we are in verbose mode, output what we are about to run (or return) Switch to using 'p4_build_cmd' If the user has configured various parameters, use them. Consistently use 'git-p4' for the configuration entries Move git-p4.syncFromOrigin into a configuration parameters section Put some documentation in about the parameters that have been added Put in the two other configuration elements found in the source contrib/fast-import/git-p4 | 71 ++++++++++++++++++++++++++++++++------- contrib/fast-import/git-p4.txt | 68 +++++++++++++++++++++++++++++++------- 2 files changed, 114 insertions(+), 25 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html