Olivier Marin <dkr+ml.git@xxxxxxx> writes: > Junio C Hamano a écrit : >> >> all the tests still pass, but we would want extra sets of eyeballs on this >> type of change to really make sure. > > OK, I read the diff and found some trivial quoting issues that will break the > following tests if $TEST_DIRECTORY contain a space: > >> t/t4101-apply-nonl.sh | 2 +- >> t/t5100-mailinfo.sh | 18 +++++++++--------- >> t/t7500-commit.sh | 16 ++++++++-------- Ah, GIT_EDITOR is dereferenced twice. Sheesh. We could probably use test_set_editor() function from test-lib.sh, hmm? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
