Re: [PATCH] Teach git log --check to return an appropriate error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] Teach git log --check to return an appropriate error code
From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
Date: Sat, 9 Aug 2008 14:05:01 +0200 (CEST)
Cc: git@xxxxxxxxxxxxxxx
In-reply-to: <1218265054-19220-1-git-send-email-4ux6as402@xxxxxxxxxxxxxx>
User-agent: Alpine 1.00 (DEB 882 2007-12-20)

Hi,

On Sat, 9 Aug 2008, Peter Valdemar Mørch wrote:

> 	Whether or not a check fails is stored in the
> 	DIFF_OPT_CHECK_FAILED field of flags in struct diff_options.
> 	This flag-field is only set (diff.c:1644), never cleared.

That is a side effect.  How wise is it to rely on that?

Ciao,
Dscho

Follow-Ups:
- Re: [PATCH] Teach git log --check to return an appropriate error code
  - From: Junio C Hamano

References:
- Re: Re* git diff/log --check exitcode and PAGER environment variable
  - From: Johannes Schindelin
- [PATCH] Teach git log --check to return an appropriate error code
  - From: Peter Valdemar Mørch

Prev by Date: Re: [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler.
Next by Date: [PATCH 2/3 v2] Teach git diff-tree --stdin to diff trees
Previous by thread: [PATCH] Teach git log --check to return an appropriate error code
Next by thread: Re: [PATCH] Teach git log --check to return an appropriate error code
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux