Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Wong <normalperson@xxxxxxxx> writes: > > > From: Marcus Griep <marcus@xxxxxxxx> > > > > Fixes bad regex match check for multiple globs (would always return > > one glob regardless of actual number). > > > > [ew: fixed a bashism in the test and some minor line-wrapping] > > Thanks both. > > > +test_expect_success 'test disallow multi-globs' ' > > ... > > + cd tmp && > > + echo "try try" >> tags/end/src/b/readme && > > + poke tags/end/src/b/readme && > > + svn commit -m "try to try" > > + cd .. && > > Do you want to ignore exit code from 'svn commit -m' here? Oops, no missed that. > In any case, I'd want to see "temporarily work in subdirectory" done in a > subshell when applicable, so that we won't have to worry about where we > are when we later add more tests, like this: > > ( > cd tmp && > echo "try try" >>tags/end/src/b/readme && > poke tags/end/src/b/readme && > svn commit -m "try to try" && > ) && Yes, that's a good idea > > + test_must_fail git-svn fetch three 2> stderr.three && > > + cmp expect.three stderr.three > > s/cmp/test_cmp/; Noted. Shall I make those changes and resubmit or are they simple enough for you to do? -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
