Hi,
On Fri, 8 Aug 2008, René Scharfe wrote:
> Johannes Schindelin schrieb:
>
> > This commit does so, by inspecting the MAKEFLAGS variable to detect if
> > the option "-j" or "--jobs" was passed to make. In that case, the
> > test is run with the new "--parallel" option.
>
> How about making the test harness be able to run multiple tests in
> parallel by default, i.e. always use a different trash directory name
> for each test, without adding the new option? The implementation would
> be a bit simpler (no -j detection needed) and the documentation would be
> simpler, too.
I am totally opposed to dropping the -j detection. This is what cost me 3
hours to research/implement. *sighs*
> > *)
> > break ;;
> > esac
> > @@ -449,6 +454,11 @@ test_done () {
> > # we will leave things as they are.
> >
> > say_color pass "passed all $msg"
> > +
> > + test ! -z = "$remove_trash" &&
>
> This test succeeds always, because = is not an empty string.
Thanks.
Ciao,
Dscho
